Revert "nodePackages: regenerate with node2nix 1.9.0" #110752
Conversation
ofborg
bot
requested review from
turboMaCk,
midchildan,
freezeboy,
michojel and
iblech
|
@SuperSandro2000 let's revert it. Weird situation. |
|
Same happened in aaf4ddd already. |
Ah possible solution right now would be to follow @raboof way to only update node2nix to 1.9.0 without regenerating zigbee2mqtt but still getting the node2nix 1.9.0 files in. |
|
maybe @raboof can also cherry pick some of my changes (e.g. the |
He indicated on IRC that you should continue this. Maybe you should try to contact him to coordinate this. |
TBQH I think @svanderburg is more qualified to take this on, but if I find some time I'll try and update #110394 - please don't wait for me though :D |
|
I have created a new PR with a second attempt: #110813 |
|
Would you mind putting a short description of why you’re reverting something in the commit message in future (could just have been what you said in the PR body here). Makes it easy to see at a glance from the git log why changes were made, which is important when looking through lots of commits. Thanks! |
Reverts #110545
@svanderburg
This breaks eval on master because zigbee2mqtt can't be currently updated. If it is updated nixpkgs-review fails with
error: stack overflow (possible infinite recursion)if no ofborg eval results are available.I've reopened #110394 which does not update zigbee2mqtt which avoids this.