Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b10ed56b8e95
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4740aa435905
Choose a head ref
  • 9 commits
  • 11 files changed
  • 8 contributors

Commits on Jan 22, 2021

  1. Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    starcraft66 Tristan
    Copy the full SHA
    e1ea0a2 View commit details

Commits on Jan 23, 2021

  1. krita: 4.4.1 -> 4.4.2

    We can re-enable parallel building, since the bug causing intermittent
    build issues is now fixed. See
    https://bugs.kde.org/show_bug.cgi?id=431226 for more information.
    
    Closes #35359.
    talyz committed Jan 23, 2021
    Copy the full SHA
    923adfe View commit details

Commits on Jan 24, 2021

  1. stdenv: Remove stdenv.platform

    This was not working after #110544 as caught by @r-burns in
    #110544 (comment).
    Thankfully it isn't used anymore and I believe wasn't documented either.
    (I at least did not remember it existed.)
    Ericson2314 committed Jan 24, 2021
    1
    Copy the full SHA
    fa204a9 View commit details

Commits on Jan 25, 2021

  1. python37Packages.azure-mgmt-compute: 18.0.0 -> 18.1.0

    r-ryantm authored and Jonathan Ringer committed Jan 25, 2021
    Copy the full SHA
    f0b3780 View commit details
  2. Merge pull request #110574 from talyz/krita-4.4.2

    krita: 4.4.1 -> 4.4.2
    lovesegfault authored Jan 25, 2021
    Copy the full SHA
    6556b1f View commit details
  3. Merge pull request #110529 from r-ryantm/auto-update/picard-tools

    picard-tools: 2.24.0 -> 2.24.1
    ryantm authored Jan 25, 2021
    Copy the full SHA
    afebf1c View commit details
  4. Merge pull request #110726 from Ericson2314/no-stdenv-dot-platform

    stdenv: Remove stdenv.platform
    Ericson2314 authored Jan 25, 2021
    Copy the full SHA
    e8d39a9 View commit details
  5. pkgs/build-support: stdenv.lib -> lib

    siraben authored and cole-h committed Jan 25, 2021
    Copy the full SHA
    aa8868c View commit details
  6. Copy the full SHA
    4740aa4 View commit details
7 changes: 2 additions & 5 deletions pkgs/applications/graphics/krita/default.nix
Original file line number Diff line number Diff line change
@@ -10,16 +10,13 @@

mkDerivation rec {
pname = "krita";
version = "4.4.1";
version = "4.4.2";

src = fetchurl {
url = "https://download.kde.org/stable/${pname}/${version}/${pname}-${version}.tar.xz";
sha256 = "1bmmfvmawnlihbqkksdrwxfkaip4nfsi97w83fmvkyxl4jk715vr";
sha256 = "121fjdv5phx1aqk21vx9k9vsc5k1w8s86gp6pamy2y31r2ph7r8y";
};

# *somtimes* fails with can't find ui_manager.h, also see https://github.com/NixOS/nixpkgs/issues/35359
enableParallelBuilding = false;

nativeBuildInputs = [ cmake extra-cmake-modules python3Packages.sip makeWrapper ];

buildInputs = [
4 changes: 2 additions & 2 deletions pkgs/applications/science/biology/picard-tools/default.nix
Original file line number Diff line number Diff line change
@@ -2,11 +2,11 @@

stdenv.mkDerivation rec {
pname = "picard-tools";
version = "2.24.0";
version = "2.24.1";

src = fetchurl {
url = "https://github.com/broadinstitute/picard/releases/download/${version}/picard.jar";
sha256 = "sha256-cOkQObzMb222DxjEFxMhiozfRfWR8CwQEsBiFSsnzXs=";
sha256 = "sha256-acCsYHyZ358hYqa2haOxR+g6FQGtK+hstYfLBvHLwR8=";
};

nativeBuildInputs = [ makeWrapper ];
15 changes: 8 additions & 7 deletions pkgs/build-support/bintools-wrapper/default.nix
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@
# compiler and the linker just "work".

{ name ? ""
, lib
, stdenvNoCC
, bintools ? null, libc ? null, coreutils ? null, shell ? stdenvNoCC.shell, gnugrep ? null
, nativeTools, noLibc ? false, nativeLibc, nativePrefix ? ""
@@ -15,7 +16,7 @@
, useMacosReexportHack ? false
}:

with stdenvNoCC.lib;
with lib;

assert nativeTools -> !propagateDoc && nativePrefix != "";
assert !nativeTools ->
@@ -31,11 +32,11 @@ let
#
# TODO(@Ericson2314) Make unconditional, or optional but always true by
# default.
targetPrefix = stdenv.lib.optionalString (targetPlatform != hostPlatform)
targetPrefix = lib.optionalString (targetPlatform != hostPlatform)
(targetPlatform.config + "-");

bintoolsVersion = stdenv.lib.getVersion bintools;
bintoolsName = stdenv.lib.removePrefix targetPrefix (stdenv.lib.getName bintools);
bintoolsVersion = lib.getVersion bintools;
bintoolsName = lib.removePrefix targetPrefix (lib.getName bintools);

libc_bin = if libc == null then null else getBin libc;
libc_dev = if libc == null then null else getDev libc;
@@ -62,7 +63,7 @@ let
else if targetPlatform.system == "powerpc-linux" then "${libc_lib}/lib/ld.so.1"
else if targetPlatform.isMips then "${libc_lib}/lib/ld.so.1"
else if targetPlatform.isDarwin then "/usr/lib/dyld"
else if stdenv.lib.hasSuffix "pc-gnu" targetPlatform.config then "ld.so.1"
else if lib.hasSuffix "pc-gnu" targetPlatform.config then "ld.so.1"
else null;

expand-response-params =
@@ -326,10 +327,10 @@ stdenv.mkDerivation {
let bintools_ = if bintools != null then bintools else {}; in
(if bintools_ ? meta then removeAttrs bintools.meta ["priority"] else {}) //
{ description =
stdenv.lib.attrByPath ["meta" "description"] "System binary utilities" bintools_
lib.attrByPath ["meta" "description"] "System binary utilities" bintools_
+ " (wrapper script)";
priority = 10;
} // optionalAttrs useMacosReexportHack {
platforms = stdenv.lib.platforms.darwin;
platforms = lib.platforms.darwin;
};
}
17 changes: 9 additions & 8 deletions pkgs/build-support/cc-wrapper/default.nix
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@
# compiler and the linker just "work".

{ name ? ""
, lib
, stdenvNoCC
, cc ? null, libc ? null, bintools, coreutils ? null, shell ? stdenvNoCC.shell
, gccForLibs ? null
@@ -18,7 +19,7 @@
, libcxx ? null
}:

with stdenvNoCC.lib;
with lib;

assert nativeTools -> !propagateDoc && nativePrefix != "";
assert !nativeTools ->
@@ -34,11 +35,11 @@ let
#
# TODO(@Ericson2314) Make unconditional, or optional but always true by
# default.
targetPrefix = stdenv.lib.optionalString (targetPlatform != hostPlatform)
targetPrefix = lib.optionalString (targetPlatform != hostPlatform)
(targetPlatform.config + "-");

ccVersion = stdenv.lib.getVersion cc;
ccName = stdenv.lib.removePrefix targetPrefix (stdenv.lib.getName cc);
ccVersion = lib.getVersion cc;
ccName = lib.removePrefix targetPrefix (lib.getName cc);

libc_bin = if libc == null then null else getBin libc;
libc_dev = if libc == null then null else getDev libc;
@@ -247,8 +248,8 @@ stdenv.mkDerivation {

setupHooks = [
../setup-hooks/role.bash
] ++ stdenv.lib.optional (cc.langC or true) ./setup-hook.sh
++ stdenv.lib.optional (cc.langFortran or false) ./fortran-hook.sh;
] ++ lib.optional (cc.langC or true) ./setup-hook.sh
++ lib.optional (cc.langFortran or false) ./fortran-hook.sh;

postFixup =
# Ensure flags files exists, as some other programs cat them. (That these
@@ -353,7 +354,7 @@ stdenv.mkDerivation {
+ optionalString (libcxx.isLLVM or false) (''
echo "-isystem ${libcxx}/include/c++/v1" >> $out/nix-support/libcxx-cxxflags
echo "-stdlib=libc++" >> $out/nix-support/libcxx-ldflags
'' + stdenv.lib.optionalString stdenv.targetPlatform.isLinux ''
'' + lib.optionalString stdenv.targetPlatform.isLinux ''
echo "-lc++abi" >> $out/nix-support/libcxx-ldflags
'')

@@ -492,7 +493,7 @@ stdenv.mkDerivation {
let cc_ = if cc != null then cc else {}; in
(if cc_ ? meta then removeAttrs cc.meta ["priority"] else {}) //
{ description =
stdenv.lib.attrByPath ["meta" "description"] "System C compiler" cc_
lib.attrByPath ["meta" "description"] "System C compiler" cc_
+ " (wrapper script)";
priority = 10;
};
2 changes: 1 addition & 1 deletion pkgs/build-support/pkg-config-wrapper/default.nix
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@
, extraPackages ? [], extraBuildCommands ? ""
}:

with stdenvNoCC.lib;
with lib;

let
stdenv = stdenvNoCC;
16 changes: 8 additions & 8 deletions pkgs/build-support/release/ant-build.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{ src
, pkgs
, lib
, stdenv ? pkgs.stdenv
, name
, antTargets ? []
@@ -16,8 +17,7 @@
, ... } @ args:

let
antFlags = "-f ${buildfile} " + stdenv.lib.concatMapStrings ({name, value}: "-D${name}=${value} " ) antProperties ;
lib = stdenv.lib;
antFlags = "-f ${buildfile} " + lib.concatMapStrings ({name, value}: "-D${name}=${value} " ) antProperties ;
in
stdenv.mkDerivation (

@@ -31,7 +31,7 @@ stdenv.mkDerivation (
prePhases =
["antSetupPhase"];

antSetupPhase = with stdenv.lib; ''
antSetupPhase = with lib; ''
if test "$hydraAntLogger" != "" ; then
export ANT_ARGS="-logger org.hydra.ant.HydraLogger -lib `ls $hydraAntLogger/share/java/*.jar | head -1`"
fi
@@ -46,7 +46,7 @@ stdenv.mkDerivation (
mkdir -p $out/share/java
${ if jars == [] then ''
find . -name "*.jar" | xargs -I{} cp -v {} $out/share/java
'' else stdenv.lib.concatMapStrings (j: ''
'' else lib.concatMapStrings (j: ''
cp -v ${j} $out/share/java
'') jars }
@@ -65,7 +65,7 @@ stdenv.mkDerivation (
in
''
header "Generating jar wrappers"
'' + (stdenv.lib.concatMapStrings (w: ''
'' + (lib.concatMapStrings (w: ''
mkdir -p $out/bin
cat >> $out/bin/${w.name} <<EOF
@@ -85,7 +85,7 @@ stdenv.mkDerivation (
header "Building default ant target"
ant ${antFlags}
closeNest
'' else stdenv.lib.concatMapStrings (t: ''
'' else lib.concatMapStrings (t: ''
header "Building '${t}' target"
ant ${antFlags} ${t}
closeNest
@@ -103,12 +103,12 @@ stdenv.mkDerivation (
'';
}

// removeAttrs args ["antProperties" "buildInputs" "pkgs" "jarWrappers"] //
// removeAttrs args ["antProperties" "buildInputs" "pkgs" "lib" "jarWrappers"] //

{
name = name + (if src ? version then "-" + src.version else "");

buildInputs = [ant jre zip unzip] ++ stdenv.lib.optional (args ? buildInputs) args.buildInputs ;
buildInputs = [ant jre zip unzip] ++ lib.optional (args ? buildInputs) args.buildInputs ;

postHook = ''
mkdir -p $out/nix-support
2 changes: 1 addition & 1 deletion pkgs/build-support/release/debian-build.nix
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
{ name ? "debian-build"
, lib
, diskImage
, src, stdenv, vmTools, checkinstall
, src, lib, stdenv, vmTools, checkinstall
, fsTranslation ? false
, # Features provided by this package.
debProvides ? []
2 changes: 1 addition & 1 deletion pkgs/build-support/release/default.nix
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@ rec {
} // args);

antBuild = args: import ./ant-build.nix (
{ inherit pkgs;
{ inherit lib pkgs;
} // args);

mvnBuild = args: import ./maven-build.nix (
Original file line number Diff line number Diff line change
@@ -8,13 +8,13 @@
}:

buildPythonPackage rec {
version = "18.0.0";
version = "18.1.0";
pname = "azure-mgmt-compute";

src = fetchPypi {
inherit pname version;
extension = "zip";
sha256 = "34815c91193640ad8ff0c4dad7f2d997548c853d2e8b10250329ed516e55879e";
sha256 = "02de691c5ce7237993e65b0ae6154b3bf8ec32bcb15f13ade72bc7f3cb3183d4";
};

propagatedBuildInputs = [
9 changes: 5 additions & 4 deletions pkgs/stdenv/darwin/default.nix
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@
assert crossSystem == localSystem;

let
inherit (localSystem) system platform;
inherit (localSystem) system;

bootstrapClangVersion = "7.1.0";

@@ -80,7 +80,7 @@ in rec {

mkCC = overrides: import ../../build-support/cc-wrapper (
let args = {
inherit shell;
inherit lib shell;
inherit (last) stdenvNoCC;

nativeTools = false;
@@ -148,7 +148,7 @@ in rec {
__extraImpureHostDeps = commonImpureHostDeps;

extraAttrs = {
inherit macosVersionMin platform;
inherit macosVersionMin;
};
overrides = self: super: (overrides self super) // {
inherit ccNoLibcxx;
@@ -217,6 +217,7 @@ in rec {

binutils = lib.makeOverridable (import ../../build-support/bintools-wrapper) {
shell = "${bootstrapTools}/bin/bash";
inherit lib;
inherit (self) stdenvNoCC;

nativeTools = false;
@@ -522,7 +523,7 @@ in rec {
extraAttrs = {
libc = pkgs.darwin.Libsystem;
shellPackage = pkgs.bash;
inherit macosVersionMin platform bootstrapTools;
inherit macosVersionMin bootstrapTools;
};

allowedRequisites = (with pkgs; [
12 changes: 5 additions & 7 deletions pkgs/stdenv/linux/default.nix
Original file line number Diff line number Diff line change
@@ -42,7 +42,7 @@
assert crossSystem == localSystem;

let
inherit (localSystem) system platform;
inherit (localSystem) system;

commonPreHook =
''
@@ -107,15 +107,11 @@ let
bintools = prevStage.binutils;
isGNU = true;
libc = getLibc prevStage;
inherit lib;
inherit (prevStage) coreutils gnugrep;
stdenvNoCC = prevStage.ccWrapperStdenv;
};

extraAttrs = {
# Having the proper 'platform' in all the stdenvs allows getting proper
# linuxHeaders for example.
inherit platform;
};
overrides = self: super: (overrides self super) // { fetchurl = thisStdenv.fetchurlBoot; };
};

@@ -171,6 +167,7 @@ in
nativeLibc = false;
buildPackages = { };
libc = getLibc self;
inherit lib;
inherit (self) stdenvNoCC coreutils gnugrep;
bintools = bootstrapTools;
};
@@ -317,6 +314,7 @@ in
cc = prevStage.gcc-unwrapped;
bintools = self.binutils;
libc = getLibc self;
inherit lib;
inherit (self) stdenvNoCC coreutils gnugrep;
shell = self.bash + "/bin/bash";
};
@@ -369,7 +367,7 @@ in
# TODO: remove this!
inherit (prevStage) glibc;

inherit platform bootstrapTools;
inherit bootstrapTools;
shellPackage = prevStage.bash;
};