Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brackets: drop #110709

Merged
merged 1 commit into from Jan 24, 2021
Merged

brackets: drop #110709

merged 1 commit into from Jan 24, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

Hasn't been updated since 2017 and suffers from CVE-2019-8255.
closes #90740
closes #59196

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

The last release is from 6. April 2020. https://github.com/adobe/brackets/releases

@worldofpeace
Copy link
Contributor

Yep, lets remove this.

@dotlambda
brackets: drop
89cb93a 
Hasn't been updated since 2017 and suffers from CVE-2019-8255.
@worldofpeace worldofpeace merged commit deaf796 into NixOS:master Jan 24, 2021
@worldofpeace
Copy link
Contributor

@dotlambda Thanks ✨

@dotlambda dotlambda deleted the brackets-drop branch January 24, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@fpletz fpletz Awaiting requested review from fpletz

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 85: brackets-1.9: 1 advisory [9.8] brackets needs update
3 participants
@dotlambda @SuperSandro2000 @worldofpeace