Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beamPackages: add missing lib where needed #110708

Merged
1 commit merged into from Jan 24, 2021
Merged

beamPackages: add missing lib where needed #110708

1 commit merged into from Jan 24, 2021

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 24, 2021 •
edited

changes in 2f78ee7 missed some places where lib had to be added breaking the derivations

cc @petabyteboy who spotted the issue

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
beamPackages: add missing lib where needed
7785a53 
changes in 2f78ee7 missed some places where lib had to be added
@ghost
Copy link

ghost commented Jan 24, 2021

This is not everything, but thanks.

@ofborg build beamPackages.pc beamPackages.hex

@ghost ghost merged commit 6a30c02 into NixOS:master Jan 24, 2021
@prusnak prusnak deleted the beam-add-lib branch January 24, 2021 20:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: erlang 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@prusnak