Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: Remove stdenv.platform #110726

Merged
merged 1 commit into from Jan 25, 2021
Merged

stdenv: Remove stdenv.platform #110726

merged 1 commit into from Jan 25, 2021

Conversation

Ericson2314
Copy link
Member

Motivation for this change

This was not working after #110544 as caught by @r-burns in
#110544 (comment).
Thankfully it isn't used anymore and I believe wasn't documented either.
(I at least did not remember it existed.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ericson2314
stdenv: Remove stdenv.platform
fa204a9 
This was not working after NixOS#110544 as caught by @r-burns in
NixOS#110544 (comment).
Thankfully it isn't used anymore and I believe wasn't documented either.
(I at least did not remember it existed.)
r-burns
r-burns approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@r-burns r-burns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-build pkgs/top-level/release.nix -A tarball passes now. Thanks!

@Ericson2314 Ericson2314 merged commit e8d39a9 into NixOS:master Jan 25, 2021
@Ericson2314 Ericson2314 deleted the no-stdenv-dot-platform branch January 25, 2021 02:37
@K900 K900 mentioned this pull request Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-burns r-burns r-burns approved these changes

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @r-burns