Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spglib: init at 1.16.0 #110753

Merged
merged 1 commit into from Jan 26, 2021
Merged

spglib: init at 1.16.0 #110753

merged 1 commit into from Jan 26, 2021

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Jan 25, 2021

Motivation for this change

Small C library for finding and handling crystal symmetries.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Is this duplicated with https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/spglib/default.nix or is this just the python variant?

@markuskowa
Copy link
Member Author

markuskowa commented Jan 25, 2021

It is the same package source but this derivation builds only the C-API/library of the package. The other derivation builds the python package.

@SuperSandro2000
Copy link
Member

Would it be smart to reuse the source from their to not potentially have different versions in nixpkgs?

@markuskowa
Copy link
Member Author

markuskowa commented Jan 25, 2021

I am not sure how that would look like, as they live in different package subspaces in nixpkgs. Having different versions may not be an issue as it is unlikely that one project depends on both C-API and Python at the same time.
This solution now is at least of low complexity.
Do have a suggestion or do you know of a similar case?

@SuperSandro2000
Copy link
Member

Do have a suggestion or do you know of a similar case?

The change would probably need to happen on the python side because it would be easier. There we could do something like in the python top level file:

spglib = callPackages ../.. {
  inherit (pkgs.spglib) src;
};

But I am not sure if this would be a good idea.

@markuskowa
Copy link
Member Author

I took a look at the python package: it uses fetchpypi to get the sources and simply switching the sources to the plain GithHub sources failed and would require more work. I would suggest to keep the plain C-version and python version separate for now.

@SuperSandro2000 SuperSandro2000 merged commit 117addb into NixOS:master Jan 26, 2021
@markuskowa markuskowa deleted the add-spglib branch May 25, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants