Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cors-backdoor: init at 1.0.6 #110748

Closed
wants to merge 1 commit into from
Closed

cors-backdoor: init at 1.0.6 #110748

wants to merge 1 commit into from

Conversation

raboof
Copy link
Member

@raboof raboof commented Jan 25, 2021

Motivation for this change

despite the name, cors-backdoor is a useful tool when locally developing
browser applications that consist of several pieces, and testing them
against deployed components instead of running everything locally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof
cors-backdoor: init at 1.0.6
612a066 
despite the name, cors-backdoor is a useful tool when locally developing
browser applications that consist of several pieces, and testing them
against deployed components instead of running everything locally.
@raboof
Copy link
Member Author

raboof commented Jan 25, 2021 •
edited

nixpkgs-review fails:

HEAD is now at 40f27ff2bef Merge pull request #110545 from svanderburg/node2nix-update
$ nix-env -f /home/aengelen/.cache/nixpkgs-review/pr-110748-1/nixpkgs -qaP --xml --out-path --show-trace
error: stack overflow (possible infinite recursion)

but that seems like a problem with master, not with this PR in particular - possibly #110545 (comment)

@ofborg ofborg bot requested a review from midchildan January 25, 2021 09:43
@raboof
Copy link
Member Author

raboof commented Jan 26, 2021

let's wait until the node2nix update is in

@raboof raboof closed this Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midchildan midchildan Awaiting requested review from midchildan

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@raboof