mumble: replace python and qt514 with python3 and qt5 #110746
Conversation
| @@ -25,7 +25,7 @@ let | |||
| patches = (source.patches or []) | |||
| ++ [ ./fix-rnnoise-argument.patch ]; | |||
|
|
|||
| nativeBuildInputs = [ pkg-config python qt5.qmake ] | |||
| nativeBuildInputs = [ pkg-config python3 qt5.qmake ] | |||
There was a problem hiding this comment.
Shouldn't this use libsForQt5 instead of passing qmake in?
There was a problem hiding this comment.
In all-packages.nix mumble and murmur use callPackages but there is no libsForQt5.callPackages.
There was a problem hiding this comment.
I mean libsForQt5.callPackage.
There was a problem hiding this comment.
Is it safe to replace callPackages with libsForQt5.callPackage?
There was a problem hiding this comment.
I am not sure. It could double wrap maybe.
There was a problem hiding this comment.
This sounds like something that should be handled in a separate pull request.
|
This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 5 packages built:
|
Things done
sandboxinnix.confon non-NixOS linux)./result/bin/)