Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim: add lspsaga-nvim, zephyr-nvim, oceanic-material #110747

Merged
merged 4 commits into from Jan 25, 2021
Merged

vim: add lspsaga-nvim, zephyr-nvim, oceanic-material #110747

merged 4 commits into from Jan 25, 2021

Conversation

onsails
Copy link
Contributor

@onsails onsails commented Jan 25, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jorsn January 25, 2021 09:34
@onsails onsails marked this pull request as ready for review January 25, 2021 10:27
@onsails onsails changed the title vim: add lspsaga-nvim vim: add lspsaga-nvim zephyr-nvim oceanic-material Jan 25, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110747 run on x86_64-linux 1

25 packages built:
  • spacevim
  • vimPlugins.ale
  • vimPlugins.caw-vim
  • vimPlugins.chadtree
  • vimPlugins.coc-explorer
  • vimPlugins.coc-nvim
  • vimPlugins.denite-git
  • vimPlugins.deoplete-fish
  • vimPlugins.deoplete-khard
  • vimPlugins.deoplete-nvim
  • vimPlugins.lspsaga-nvim
  • vimPlugins.nvim-lspconfig
  • vimPlugins.oceanic-material
  • vimPlugins.oceanic-next
  • vimPlugins.plenary-nvim
  • vimPlugins.sql-nvim
  • vimPlugins.tagbar
  • vimPlugins.telescope-nvim
  • vimPlugins.vim-dadbod
  • vimPlugins.vim-floaterm
  • vimPlugins.vim-lsc
  • vimPlugins.vim-repeat
  • vimPlugins.vim-vinegar
  • vimPlugins.vimtex
  • vimPlugins.zephyr-nvim

@SuperSandro2000 SuperSandro2000 changed the title vim: add lspsaga-nvim zephyr-nvim oceanic-material vim: add lspsaga-nvim, zephyr-nvim, oceanic-material Jan 25, 2021
@SuperSandro2000 SuperSandro2000 merged commit cc75b0e into NixOS:master Jan 25, 2021
@alyssais
Copy link
Member

Hi @onsails, just say these commits in git log and thought you’d like to know that your name and email address are being recorded as "Andrey Kuznetsov" and "fear@[...].in" (including the quotes). You might want to have a look at your git config file and remove the extraneous quotes. :)

@onsails
Copy link
Contributor Author

onsails commented Jan 27, 2021 •
edited

Hi @onsails, just say these commits in git log and thought you’d like to know that your name and email address are being recorded as "Andrey Kuznetsov" and "fear@[...].in" (including the quotes). You might want to have a look at your git config file and remove the extraneous quotes. :)

hmmm, I believe it's home-manager issue... I'll look into that, thank you!

@onsails
Copy link
Contributor Author

onsails commented Jan 27, 2021

actually that's the issue with update.py-generated configs only...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorsn jorsn Awaiting requested review from jorsn

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onsails @SuperSandro2000 @alyssais