Labgrid also has a check for a specific pyserial port we maintain in the project.
Not sure how to deal with this and whether packaging the fork for nixos is fine.

If required you can maintain a fork of pyserial in the labgrid project directory.

The gitAndTools.gitstatus package has a similiar relationship to a libgit2 fork if you're interested in how it's done.

You can simply take the original pyserial package and override what is different, most probably the src attribute, like in https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/version-management/git-and-tools/gitstatus/romkatv_libgit2.nix

We merged the patches into our pyserial. Upstream should really accept them, and if they don't then eventually downstreams are just going to roll those patches on their own.

If you can tell from my suggestions I can't find anything wrong with this expression.

If you can tell from my suggestions I can't find anything wrong with this expression.

I fixed up both suggestions and added a patch to remove the pyserial check (which uses the pyserial version and won't work for NixOS any longer, since NixOS applies the patches downstream). Thanks for the review, this should be good to go now.

This looks a bit odd, but it does not seem to cause issues. Do you know whats happening here? @Emantor

=============== 201 passed, 31 skipped, 27 deselected in 36.30s ================
An exception occured during cleanup, call the cleanup() method on targets yourself to handle exceptions explictly.
Error: {} [Errno 2] No such file or directory: 'ssh'
An exception occured during cleanup, call the cleanup() method on targets yourself to handle exceptions explictly.
Error: {} [Errno 2] No such file or directory: 'ssh'
An exception occured during cleanup, call the cleanup() method on targets yourself to handle exceptions explictly.
Error: {} child has vanished
Finished executing pytestCheckPhase

Apart from that I'm also content with the state of this.

This looks a bit odd, but it does not seem to cause issues. Do you know whats happening here? @Emantor

=============== 201 passed, 31 skipped, 27 deselected in 36.30s ================
An exception occured during cleanup, call the cleanup() method on targets yourself to handle exceptions explictly.
Error: {} [Errno 2] No such file or directory: 'ssh'
An exception occured during cleanup, call the cleanup() method on targets yourself to handle exceptions explictly.
Error: {} [Errno 2] No such file or directory: 'ssh'
An exception occured during cleanup, call the cleanup() method on targets yourself to handle exceptions explictly.
Error: {} child has vanished
Finished executing pytestCheckPhase

Apart from that I'm also content with the state of this.

Yes, we do have some tests which setup a mocked SSH connection, but during teardown we try to cleanup all connections. The cleanup tries to use ssh, but this is not available during the test run on NixOS. The cleanup code was added after the tests were introduced and almost every other platform does have ssh available while running the tests. IMO this is fine to ignore for now, I'll fix the tests for the next release so this should vanish on the next update.