Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin.CoreFoundation: update to swift newest version #110357

Draft
wants to merge 2 commits into
base: staging
Choose a base branch
from
Draft

darwin.CoreFoundation: update to swift newest version #110357

wants to merge 2 commits into from

Conversation

holymonson
Copy link
Contributor

Motivation for this change

This PR is almost done, but it needs libdispatch update to macos-10.13 or above to provide DISPATCH_APPLY_AUTO. (#101229)
Also, it may need a newer ICU.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@holymonson
darwin.CoreFoundation: rename CF -> CoreFoundation
6ab94cc 
CF on apple opensource is no longer released, we should use its formal name CoreFoundation
according to swift-corelibs-foundation.
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: haskell 6.topic: stdenv Standard environment labels Jan 21, 2021
@supermarin
Copy link
Contributor

@holymonson @SuperSandro2000 can we move this forward and update Swift to 5.5?

@holymonson
Copy link
Contributor Author

@holymonson @SuperSandro2000 can we move this forward and update Swift to 5.5?

Seems not, we are still waiting for a new macos SDK (#116341 #101229).

@supermarin
Copy link
Contributor

Sounds good, will keep an eye on the other ones

@stale
Copy link

stale bot commented Jan 8, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 8, 2022
@shlevy shlevy removed their request for review October 13, 2022 12:06
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 13, 2022
@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@2xsaiko 2xsaiko mentioned this pull request May 1, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@aflatter aflatter Awaiting requested review from aflatter

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@sternenseemann sternenseemann Awaiting requested review from sternenseemann sternenseemann will be requested when the pull request is marked ready for review sternenseemann is a code owner

@maralorn maralorn Awaiting requested review from maralorn maralorn will be requested when the pull request is marked ready for review maralorn is a code owner

@ncfavier ncfavier Awaiting requested review from ncfavier ncfavier will be requested when the pull request is marked ready for review ncfavier is a code owner

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 will be requested when the pull request is marked ready for review Ericson2314 is a code owner

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: darwin Running or building packages on Darwin 6.topic: haskell 6.topic: stdenv Standard environment 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@holymonson @supermarin @SuperSandro2000 @wegank