Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-cpp: add pkgconfig data #110312

Merged
merged 1 commit into from Jan 21, 2021
Merged

prometheus-cpp: add pkgconfig data #110312

merged 1 commit into from Jan 21, 2021

Conversation

HectorAE
Copy link
Contributor

Motivation for this change

This may help developers easily integrate prometheus-cpp into their applications.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 marked this pull request as ready for review January 21, 2021 21:02
@Ericson2314 Ericson2314 merged commit e61a96d into NixOS:master Jan 21, 2021
@Ericson2314 Ericson2314 deleted the prometheus-cpp-pkgconfig branch January 21, 2021 21:02
@Ericson2314 Ericson2314 changed the title [Draft] prometheus-cpp: add pkgconfig data prometheus-cpp: add pkgconfig data Jan 21, 2021
@Ericson2314 Ericson2314 mentioned this pull request Jan 21, 2021
Closed
@Ericson2314
Copy link
Member

I opened jupp0r/prometheus-cpp#447 to track doing this upstream instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HectorAE @Ericson2314