Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feh: 3.6.1 -> 3.6.2 #110297

Merged
merged 1 commit into from Jan 22, 2021
Merged

feh: 3.6.1 -> 3.6.2 #110297

merged 1 commit into from Jan 22, 2021

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 21, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin, Ma27, viric and WilliButz January 21, 2021 09:38
@iblech
Copy link
Contributor

iblech commented Jan 21, 2021

Result of nixpkgs-review pr 110297 run on x86_64-linux 1

8 packages built:
  • betterlockscreen
  • deco
  • feh
  • multilockscreen
  • python37Packages.pywal
  • pywal (python38Packages.pywal)
  • python39Packages.pywal
  • wpgtk

@iblech
Copy link
Contributor

iblech commented Jan 21, 2021

Thank you for the bump! LGTM. I confirm that feh builds as it should and furthermore it appears to work. I also had a cursory look at the source diff between 3.6.1 and 3.6.2.

@Ma27 Ma27 merged commit 7c0db07 into NixOS:master Jan 22, 2021
@bbigras bbigras deleted the feh branch January 22, 2021 21:23
@bbigras
Copy link
Contributor Author

bbigras commented Jan 22, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@Ma27 Ma27 Awaiting requested review from Ma27

@viric viric Awaiting requested review from viric

@WilliButz WilliButz Awaiting requested review from WilliButz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @iblech @Ma27