Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qbittorrent: 4.3.1 -> 4.3.3 #110296

Merged
merged 1 commit into from Jan 26, 2021
Merged

qbittorrent: 4.3.1 -> 4.3.3 #110296

merged 1 commit into from Jan 26, 2021

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 21, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Anton-Latukha January 21, 2021 09:34
@Anton-Latukha
Copy link
Contributor

Anton-Latukha commented Jan 21, 2021 •
edited

@bbigras, thank you.

Repository & changelogs show regular project update.

From relevant for maintenance:
4.3.3:

MACOS: QMake: Raise minimal macOS target version to 10.14 (glasses)

(qBittorrent normally uses ./configure && make && make install, afair QMake are an alternative "unofficial" way to assemble the project.

LINUX: Use legacy 'data' directory only as a fallback (lbilli)
OTHER: Bump project requirement to C++17 (Chocobo1)

4.3.2:

OTHER: Drop support for building with libtorrent < 1.2.11 (Vladimir Golovnev)

They mean libtorrent that is libtorrent-rasterbar.

libtorrent-rasterbar 2.0.2 is current. petabyteboy already switched the Nixpkgs (so also qBittorrent) to libtorrent-rasterbar 2.0 a month ago, all seems great.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/335

cole-h
cole-h approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. UI runs fine, didn't try to download anything though.

Result of nixpkgs-review pr 110296 run on x86_64-linux 1

2 packages built:
  • qbittorrent
  • qbittorrent-nox

@cole-h cole-h merged commit 1913ea8 into NixOS:master Jan 26, 2021
@bbigras bbigras deleted the qbittorrent branch January 26, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anton-Latukha Anton-Latukha Anton-Latukha approved these changes

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @Anton-Latukha @nixos-discourse @cole-h