concurrentqueue: init at 1.0.2. #110319
Closed
concurrentqueue: init at 1.0.2. #110319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invokesus
force-pushed
the
contrib/concurrentqueue
branch
from
b571e8f
to
e239a2d
Compare
|
Thanks for the review! Made the changes. :) |
invokesus
force-pushed
the
contrib/concurrentqueue
branch
from
e239a2d
to
84fda41
Compare
| ''; | ||
|
|
||
| #_FORTIFY_SOURCE requires compiling with optimization (-O) | ||
| NIX_CFLAGS_COMPILE = "-O"; |
There was a problem hiding this comment.
Do you know if you can set CFLAGS instead? NIX_CFLAGS_COMPILE should be the last resort.
Comment on lines
+33
to
+34
| description = | ||
| "A fast multi-producer, multi-consumer lock-free concurrent queue for C++11"; |
There was a problem hiding this comment.
Suggested change
| description = | |
| "A fast multi-producer, multi-consumer lock-free concurrent queue for C++11"; | |
| description = "A fast multi-producer, multi-consumer lock-free concurrent queue for C++11"; |
Treewide will be easier if everything has a standard format.
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity from author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)