Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perldevel: 5.33.5 -> 5.33.6, perl-cross: b444794 -> 4c55233 #110321

Merged
merged 1 commit into from Jan 23, 2021

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jan 21, 2021

Motivation for this change

https://metacpan.org/pod/release/HYDAHY/perl-5.33.6/pod/perldelta.pod

dependencies:
perl-cross: arsv/perl-cross@b444794 -> arsv/perl-cross@4c55233

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp
Copy link
Member Author

stigtsp commented Jan 21, 2021

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perldevel
@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.perldevel
@GrahamcOfBorg build pkgsMusl.perldevel
@GrahamcOfBorg build pkgsi686Linux.perldevel
@GrahamcOfBorg build perldevel

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perl
@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.perl

@stigtsp
Copy link
Member Author

stigtsp commented Jan 21, 2021

@GrahamcOfBorg build perldevelPackages.Moose perldevelPackages.DBI

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110321 run on x86_64-linux 1

1 package built:
  • perldevel

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

perldevel:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern '/nix/store/fr5gpdf3m2nqq6g3v6x1vvgi7cg6px8b-gcc-wrapper-10.2.0' doesn't match anything in file '/nix/store/3j4y5pc2h4dfxrjwjpcv85m7g4m95ims-perl-5.33.6/lib/perl5/5.33.6/x86_64-linux-thread-multi/Config_heavy.pl'
substituteStream(): WARNING: pattern '/nix/store/ki7ddibjp6xbdjgjgdqwar9ivhn6b9pb-perl-5.33.6-man' doesn't match anything in file '/nix/store/3j4y5pc2h4dfxrjwjpcv85m7g4m95ims-perl-5.33.6/lib/perl5/5.33.6/x86_64-linux-thread-multi/Config_heavy.pl'

Please check the offending substituteInPlace for typos or changes in source.

@stigtsp
Copy link
Member Author

stigtsp commented Jan 21, 2021

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
[..]
Please check the offending substituteInPlace for typos or changes in source.

Hi, I don't think this is a good idea: Changing the substituteInPlace in the postInstall will trigger a mass rebuild as it would affect perl532, and perl530, not only perldevel. Also, this is out of scope for this PR.

@stigtsp stigtsp requested a review from zakame January 22, 2021 01:11
@zakame
Copy link
Member

zakame commented Jan 22, 2021

@stigtsp is right, also we're expecting a 5.32.1 release by this weekend as announced in the 5.32.1-RC1 release.

@zakame
Copy link
Member

zakame commented Jan 22, 2021

Result of nixpkgs-review pr 110321 run on Other x86_64-linux 1

1 package built:
  • perldevel

@stigtsp stigtsp merged commit b8c3cd1 into NixOS:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants