Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 1.18.78 -> 1.19.86 #110277

Closed
wants to merge 1 commit into from
Closed

brave: 1.18.78 -> 1.19.86 #110277

wants to merge 1 commit into from

Conversation

Rosuavio
Copy link

Motivation for this change

Update to new version of brave that has some IPFS support
https://brave.com/ipfs-support/

Things done

Update to new brave version and hash.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from rht, nasirhm and uskudnik January 21, 2021 05:57
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110277 run on x86_64-linux 1

1 package built:
  • brave

@bbjubjub2494 bbjubjub2494 mentioned this pull request Jan 21, 2021
Merged
@ryantm
Copy link
Member

ryantm commented Jan 21, 2021

@RosarioPulella Thanks for the update, I merged #110329 which should basically be identical, since it had maintainer approval.

@ryantm ryantm closed this Jan 21, 2021
@Rosuavio Rosuavio deleted the update/brave branch September 4, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rht rht Awaiting requested review from rht

@nasirhm nasirhm Awaiting requested review from nasirhm

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rosuavio @SuperSandro2000 @ryantm @Janik-Haag