Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab-runner: 13.7.0 -> 13.8.0 #110280

Merged
merged 1 commit into from Jan 21, 2021
Merged

gitlab-runner: 13.7.0 -> 13.8.0 #110280

merged 1 commit into from Jan 21, 2021

Conversation

max-wittig
Copy link
Contributor

@max-wittig max-wittig commented Jan 21, 2021 •
edited

Motivation for this change

https://gitlab.com/gitlab-org/gitlab-runner/blob/v13.8.0/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @bachp @zimbatm @globin @dlouzan

@ofborg ofborg bot requested review from globin, zimbatm and bachp January 21, 2021 07:21
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110280 run on x86_64-linux 1

1 package built:
  • gitlab-runner

bachp
bachp approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed

@zimbatm zimbatm merged commit 4c7ffbc into NixOS:master Jan 21, 2021
@max-wittig max-wittig deleted the patch-8 branch January 21, 2021 12:00
globin pushed a commit to mayflower/nixpkgs that referenced this pull request Mar 27, 2021
@max-wittig @globin
gitlab-runner: 13.7.0 -> 13.8.0 (NixOS#110280)
4d4dc80 
(cherry picked from commit 4c7ffbc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@globin globin Awaiting requested review from globin

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@max-wittig @SuperSandro2000 @bachp @zimbatm