scripts/install-nix-from-closure: only show progress if a terminal is used #4468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be reasonable to detect if the command is not run in an interactive shell and then activate this automatically? |
|
I agree it would probably be better to just check for a terminal ( |
… used
While the progress dots during the copying of the store work fine on a
normal terminal, those look pretty off if the script is run inside a
provisioning script of e.g. `vagrant` or `packer` where `stderr` and
`stdout` are captured:
default: .
default: ..
default: .
default: .
default: .
To work around this, the script checks with `-t 0` if it's
running on an actual terminal and doesn't show the progress if that's not
the case.
Ma27
force-pushed
the
installer-no-progress-opt
branch
from
5efa43d
to
d9367a2
Compare
Ma27
changed the title
--no-progress option
|
@edolstra @SuperSandro2000 updated the PR :) |
|
cc @edolstra anything else to do ? :) |
|
@edolstra is there any chance to include this in the next 2.3.x if another one is planned? This is for at least one project I'm working on an improvement as this would make the provisioning output readable :) |
|
Yes, I've just cherry-picked it to 2.3 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the progress dots during the copying of the store work fine on a
normal terminal, those look pretty off if the script is run inside a
provisioning script of e.g.
vagrantorpackerwherestderrandstdoutare captured:To work around this, the script checks with
-t 0if it'srunning on an actual terminal and doesn't show the progress if that's not
the case.