Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broot: 1.1.10 -> 1.2.0 #110301

Merged
merged 1 commit into from Jan 21, 2021
Merged

broot: 1.1.10 -> 1.2.0 #110301

merged 1 commit into from Jan 21, 2021

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 21, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from danieldk January 21, 2021 10:06
@doronbehar doronbehar merged commit 8c2215b into NixOS:master Jan 21, 2021
@bbigras bbigras deleted the broot branch January 21, 2021 14:58
@bbigras
Copy link
Contributor Author

bbigras commented Jan 21, 2021

Thanks!

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110301 run on x86_64-darwin 1

1 package built:
  • broot

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

broot:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern '"/bin/' doesn't match anything in file 'src/verb/builtin.rs'

Please check the offending substituteInPlace for typos or changes in source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk Awaiting requested review from danieldk

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @SuperSandro2000 @doronbehar