Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appgate-sdp: 5.1.2 -> 5.3.2 #110347

Merged
merged 1 commit into from Jan 22, 2021
Merged

appgate-sdp: 5.1.2 -> 5.3.2 #110347

merged 1 commit into from Jan 22, 2021

Conversation

ymatsiuk
Copy link
Contributor

@ymatsiuk ymatsiuk commented Jan 21, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ymatsiuk
Copy link
Contributor Author

Result of nixpkgs-review pr 110347 run on x86_64-linux 1

1 package built:
  • appgate-sdp

@etu
Copy link
Contributor

etu commented Jan 21, 2021

@ymatsiuk I just found out that this was packaged through this PR. You're my hero now. I've needed this at work for months but it's so many people that have issues with it that I've just said that it "doesn't work for me". I'll test this on our company "vpn" tomorrow :)

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110347 run on x86_64-linux 1

1 package built:
  • appgate-sdp

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

appgate-sdp:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '/opt/' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/opt/appgate/linux/appgate-resolver.pre'
substituteStream(): WARNING: pattern '/usr/sbin/dnsmasq' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/opt/appgate/linux/appgate-resolver.pre'
substituteStream(): WARNING: pattern 'InaccessiblePaths=/mnt /srv /boot /media' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/opt/appgate/linux/appgate-resolver.pre'
substituteStream(): WARNING: pattern '/opt/' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/opt/appgate/linux/appgate-dumb-resolver.pre'
substituteStream(): WARNING: pattern '/usr/sbin/dnsmasq' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/opt/appgate/linux/appgate-dumb-resolver.pre'
substituteStream(): WARNING: pattern 'InaccessiblePaths=/mnt /srv /boot /media' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/opt/appgate/linux/appgate-dumb-resolver.pre'
substituteStream(): WARNING: pattern '/usr/sbin/dnsmasq' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/lib/systemd/system/appgatedriver.service'
substituteStream(): WARNING: pattern 'cat' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/lib/systemd/system/appgatedriver.service'
substituteStream(): WARNING: pattern 'pkill' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/lib/systemd/system/appgatedriver.service'
substituteStream(): WARNING: pattern '/usr/sbin/dnsmasq' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/lib/systemd/system/appgate-dumb-resolver.service'
substituteStream(): WARNING: pattern 'InaccessiblePaths=/mnt /srv /boot /media' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/lib/systemd/system/appgate-dumb-resolver.service'
substituteStream(): WARNING: pattern 'cat' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/lib/systemd/system/appgate-dumb-resolver.service'
substituteStream(): WARNING: pattern 'pkill' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/lib/systemd/system/appgate-dumb-resolver.service'
substituteStream(): WARNING: pattern 'InaccessiblePaths=/mnt /srv /boot /media' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/lib/systemd/system/appgate-resolver.service'
substituteStream(): WARNING: pattern 'cat' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/lib/systemd/system/appgate-resolver.service'
substituteStream(): WARNING: pattern 'pkill' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/lib/systemd/system/appgate-resolver.service'
substituteStream(): WARNING: pattern 'service appgate-resolver stop' doesn't match anything in file '/nix/store/yr3zkwws4122bk0l8scdv94hvklhvia6-appgate-sdp-5.3.2/opt/appgate/linux/set_dns'

Please check the offending substituteInPlace for typos or changes in source.

@ymatsiuk
Copy link
Contributor Author

@SuperSandro2000 last time I've been asking this I got this. But sure, let me fix this 😄

@etu
Copy link
Contributor

etu commented Jan 21, 2021

@SuperSandro2000 It's not uncommon that we loop over a list of files and do substituteInPlace with things that don't exist in all the files. Mostly because it's cleaner code and nicer. The warnings doesn't matter. It's more important with code that is easier to read. I see no need for @ymatsiuk to change that.

@ymatsiuk ymatsiuk changed the title appgate-sdp: 5.1.2 -> 5.3.2 WIP: appgate-sdp: 5.1.2 -> 5.3.2 Jan 21, 2021
@SuperSandro2000
Copy link
Member

The warnings doesn't matter.

In this case the warnings do not matter but I am not sure if and how we want to filter this.

@ymatsiuk ymatsiuk changed the title WIP: appgate-sdp: 5.1.2 -> 5.3.2 appgate-sdp: 5.1.2 -> 5.3.2 Jan 21, 2021
@ymatsiuk
Copy link
Contributor Author

ymatsiuk commented Jan 21, 2021 •
edited

Fixed warnings and added shell substring magic for version calculation @SuperSandro2000 😃

etu
etu requested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just pulled this in on my system with the fixed download link (as per my comment) through an overlay and rebooted with that as a generation. And I must say, it works, and this will make my life so much easier 😄

I'm ready to merge this whenever the link is fixed.

@ymatsiuk
Copy link
Contributor Author

ymatsiuk commented Jan 22, 2021 •
edited

@etu Thanks for suggestion. Applied.

PS: I've seen you mentioned appgate in IRC but I did some research and found 0 nix expressions. I was going to poke you, to help me test this out. I'm using it on a daily basis for a month already and see no issues. And BTW I've contacted the AUR maintainer (who works for the company owner of appgate) and he confirmed that tray icon doesn't work currently 🤷🏻‍♂️

@etu etu merged commit 907cb4c into NixOS:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@etu etu etu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ymatsiuk @etu @SuperSandro2000