Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] chromium: 87.0.4280.141 -> 88.0.4324.96 #110349

Merged
merged 12 commits into from Jan 24, 2021

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 21, 2021

Motivation for this change

Backport of #110010 (and aee78d4).
cc @Frostman

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

As a first step to automate the commit messages as well.

(cherry picked from commit 76fe724)
I did a quick, automated test by reusing the VM test for Chromium.

(cherry picked from commit aee78d4)
Only execute Ctrl+w to close the currently active window if the
new/secondary window (title: "New Tab") could be selected. This fixes a
test failure since the update to Chromium M88 (cc PR NixOS#110010).
Without this additional check the main window (title: "startup done")
could still be selected (and thus will be closed) and the script would
close both windows (i.e. terminate Chromium completely).

(cherry picked from commit 8a7a844)
By default only `chromium` will be tested but other "channels" can be
selected using e.g.:
nix-build nixos/tests/chromium.nix -A ungoogled

This also adds me as secondary maintainer (I'd like to get notified on
PRs/issues and can review them).

(cherry picked from commit ff8866e)
@primeos primeos changed the title chromium: 87.0.4280.141 -> 88.0.4324.96 [20.09] chromium: 87.0.4280.141 -> 88.0.4324.96 Jan 21, 2021
@primeos
Copy link
Member Author

primeos commented Jan 24, 2021

Tested using nixosTests.chromium.

@primeos primeos merged commit cacb9ac into NixOS:release-20.09 Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant