Custom state: Update the IDL interface for 'states' attribute #27267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 21, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2639345
branch
3 times, most recently
from
20942cc
to
77cd5cd
Compare
In order to conform to the latest specification [1], this CL changes the
type of 'states' attribute from 'DOMTokenList' to 'CustomStateSet',
which is a 'setlike<DOMString>.'
* dom_token_list.{cc,h}
Remove 'virtual' from 'value()' and 'setValue()'. No one overrides
them.
* custom_state_set.{cc,h,idl}
Added.
* element_internals.{cc,h,idl}
Switch 'states' implementation.
Remove 'CustomStatesTokenList' class
* wpt/custom-elements/state/tentative/
Update tests for the new interface
This feature is not shipped yet.
[1] https://wicg.github.io/custom-state-pseudo-class/
Bug: 1012098
Change-Id: I642d16f96449db93cc9c4dc1211c7f242e608192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639345
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845986}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2639345
branch
from
77cd5cd
to
b11cd52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to conform to the latest specification [1], this CL changes the
type of 'states' attribute from 'DOMTokenList' to 'CustomStateSet',
which is a 'setlike<DOMString>.'
dom_token_list.{cc,h}
Remove 'virtual' from 'value()' and 'setValue()'. No one overrides
them.
custom_state_set.{cc,h,idl}
Added.
element_internals.{cc,h,idl}
Switch 'states' implementation.
Remove 'CustomStatesTokenList' class
wpt/custom-elements/state/tentative/
Update tests for the new interface
This feature is not shipped yet.
[1] https://wicg.github.io/custom-state-pseudo-class/
Bug: 1012098
Change-Id: I642d16f96449db93cc9c4dc1211c7f242e608192
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639345
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845986}