Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nheko: 0.7.2 -> 0.8.0 #110269

Merged
merged 2 commits into from Jan 21, 2021
Merged

nheko: 0.7.2 -> 0.8.0 #110269

merged 2 commits into from Jan 21, 2021

Conversation

maralorn
Copy link
Member

Includes
mtxclient: 0.3.1 -> 0.4.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fpletz and Ekleog January 21, 2021 02:50
SuperSandro2000
SuperSandro2000 reviewed Jan 21, 2021
View reviewed changes
pkgs/development/libraries/mtxclient/default.nix
@@ -14,13 +14,13 @@

stdenv.mkDerivation rec {
pname = "mtxclient";
version = "0.3.1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this update into a separate commit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110269 run on x86_64-linux 1

2 packages built:
  • mtxclient
  • nheko

@SuperSandro2000 SuperSandro2000 merged commit d158fe4 into NixOS:master Jan 21, 2021
@pstn
Copy link
Contributor

pstn commented Jan 21, 2021

This is missing support for the calling feature which needs gstreamer and plugins at build time to be enabled.

@pstn
Copy link
Contributor

pstn commented Jan 21, 2021

Also the dependency on libsoduim has not been removed. Please read release notes before blindly updating packages.

@maralorn
Copy link
Member Author

Hey @pstn thanks for the feedback. I actually read the release notes. (At least most of it.) I just didn‘t know that "for packagers" notes at the end of release notes are a thing.

@maralorn maralorn deleted the nheko branch January 21, 2021 18:20
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jan 22, 2021

I'm working on enabling the voip support. I tried adding gstreamer and the recommended plugins (base, good, bad) but it's still missing something: the embedded video player is not working and call don't start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@fpletz fpletz Awaiting requested review from fpletz

@Ekleog Ekleog Awaiting requested review from Ekleog

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maralorn @SuperSandro2000 @pstn @rnhmjoj