Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shotwell: 0.31.2 -> 0.31.3 #110289

Merged
merged 1 commit into from Jan 21, 2021
Merged

shotwell: 0.31.2 -> 0.31.3 #110289

merged 1 commit into from Jan 21, 2021

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 21, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/j7wcr4nkgji5rz4480fm3ng2nqglza20-shotwell-0.31.2 1.2G
/nix/store/m8i084pqrl85lr15v5yvkqklxmkfkx47-shotwell-0.31.3 1.2G

@ofborg ofborg bot requested a review from domenkozar January 21, 2021 09:06
@hugolgst
Copy link
Member

Result of nixpkgs-review pr 110289 1

1 package built:
  • shotwell (gnome3.shotwell)

@SuperSandro2000 SuperSandro2000 merged commit d3a090c into NixOS:master Jan 21, 2021
@bbigras bbigras deleted the shotwell branch January 21, 2021 17:56
@bbigras
Copy link
Contributor Author

bbigras commented Jan 21, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugolgst hugolgst hugolgst approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @hugolgst @SuperSandro2000