elfio: init at 3.8 #110322
Closed
elfio: init at 3.8 #110322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invokesus
force-pushed
the
contrib/elfio
branch
2 times, most recently
from
2bb04d5
to
1973091
Compare
SuperSandro2000
requested changes
Jan 21, 2021
Comment on lines
13
to
14
|
|
||
| phases = [ "unpackPhase" "installPhase" ]; |
There was a problem hiding this comment.
Suggested change
| phases = [ "unpackPhase" "installPhase" ]; |
Please never overwrite phases. This breaks many of the hooks used inside nixpkgs.
There was a problem hiding this comment.
Okay. Removed it. Should I add dontBuild or dontConfigure then?
invokesus
force-pushed
the
contrib/elfio
branch
from
1973091
to
27e5228
Compare
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
SuperSandro2000
requested changes
Nov 7, 2022
Comment on lines
+15
to
+16
| mkdir -p $out/include | ||
| cp -R ./elfio $out/include |
There was a problem hiding this comment.
Suggested change
| mkdir -p $out/include | |
| cp -R ./elfio $out/include | |
| mkdir -p $out/include | |
| cp -R ./elfio $out/include |
stale
bot
removed
2.status: stale
|
Another elfio expr was added to nixpkgs in the meantime: 3e231f0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)