Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protonvpn-cli: 2.2.4 -> 2.2.6 #110340

Merged
merged 1 commit into from Jan 31, 2021
Merged

protonvpn-cli: 2.2.4 -> 2.2.6 #110340

merged 1 commit into from Jan 31, 2021

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jtcoolen January 21, 2021 14:11
jtcoolen
jtcoolen approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@jtcoolen jtcoolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 110340 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • protonvpn-cli

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110340 run on x86_64-linux 1

2 packages built:
  • protonvpn-cli
  • protonvpn-gui

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

protonvpn-gui:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@jtcoolen
Copy link
Member

Result of nixpkgs-review pr 110340 run on x86_64-darwin 1
1 package marked as broken and skipped:

Indeed, protonvpn-cli targets linux; platforms.linux should be set rather than unix. Can you make this change @SCOTT-HAMILTON, please? Do not hesitate to add yourself to the maintainers' list.

@ofborg ofborg bot requested a review from jtcoolen January 21, 2021 17:24
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110340 run on x86_64-linux 1

2 packages built:
  • protonvpn-cli
  • protonvpn-gui

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

protonvpn-gui:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@jtcoolen
Copy link
Member

It looks like the protonvpn-gui package is missing a doCheck = false; line. Can we merge this change first and take care of the latter in a subsequent pull request, please? @SuperSandro2000

@SuperSandro2000 SuperSandro2000 merged commit 2b55866 into NixOS:master Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcoolen jtcoolen jtcoolen approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SCOTT-HAMILTON @SuperSandro2000 @jtcoolen