Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #180: No proper error message was given, if an unreferenced Strin… #181

Merged
merged 1 commit into from Jan 21, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Jan 6, 2021

…g was unable to allocate an id

@FLHerne
Copy link
Contributor

FLHerne commented Jan 6, 2021

The error message still isn't very user-friendly, it doesn't explain that the failure is due to hitting a limit nor what that limit is.

Something like the one for items would be better: "Unable to allocate ID for string, no more free IDs available (maximum is {:d})" ?

The regression-test failure is odd and seems unrelated to this change?

@glx22
Copy link
Contributor Author

glx22 commented Jan 6, 2021

Regression failure is caused by newer version of pillow.
And I agree, I'll update the message.

LordAro
LordAro previously approved these changes Jan 21, 2021
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glx22 glx22 merged commit 3ea1d89 into OpenTTD:master Jan 21, 2021
@glx22 glx22 deleted the string_id branch January 21, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants