Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jfrog-cli: init at 1.43.2 #110339

Closed
wants to merge 1 commit into from
Closed

jfrog-cli: init at 1.43.2 #110339

wants to merge 1 commit into from

Conversation

invokesus
Copy link
Contributor

@invokesus invokesus commented Jan 21, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@invokesus
Copy link
Contributor Author

I couldn't find a clean way of passing -o jfrog to go build, hence the postInstall. Let me know if there's a better way. :)

@invokesus
Copy link
Contributor Author

Thanks for the review. Made the changes.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110339 run on x86_64-darwin 1

1 package built:
  • jfrog-cli

@invokesus
Copy link
Contributor Author

Thanks for the review, @SuperSandro2000! Made the changes.

SuperSandro2000
SuperSandro2000 requested changes Jan 25, 2021
View reviewed changes
pkgs/development/tools/misc/jfrog-cli/default.nix
Comment on lines +27 to +28
mv $out/bin/jfrog-cli $out/bin/jfrog
ln -s $out/bin/jfrog $out/bin/jfrog-cli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mv $out/bin/jfrog-cli $out/bin/jfrog
ln -s $out/bin/jfrog $out/bin/jfrog-cli
ln -s $out/bin/jfrog-cli $out/bin/jfrog

@stale
Copy link

stale bot commented Jul 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 26, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

@terlar terlar mentioned this pull request Nov 16, 2022
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@invokesus @SuperSandro2000 @grahamc