Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvmaf: 2.1.0 -> 2.1.1 #110324

Merged
merged 1 commit into from Jan 22, 2021
Merged

libvmaf: 2.1.0 -> 2.1.1 #110324

merged 1 commit into from Jan 22, 2021

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 21, 2021

Motivation for this change

https://github.com/Netflix/vmaf/releases/tag/v2.1.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cfsmp3 January 21, 2021 12:18
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110324 run on x86_64-darwin 1

18 packages marked as broken and skipped:
  • liquidsoap
  • python37Packages.baselines
  • python37Packages.gym
  • python37Packages.pyglet
  • python37Packages.pytmx
  • python37Packages.rl-coach
  • python37Packages.roboschool
  • python38Packages.baselines
  • python38Packages.gym
  • python38Packages.pyglet
  • python38Packages.pytmx
  • python38Packages.rl-coach
  • python38Packages.roboschool
  • python39Packages.baselines
  • python39Packages.gym
  • python39Packages.pyglet
  • python39Packages.pytmx
  • python39Packages.roboschool
1 package failed to build and are new build failure:
7 packages built:
  • ffmpeg-full
  • handbrake
  • libvmaf
  • olive-editor
  • python37Packages.pydub
  • python38Packages.pydub
  • python39Packages.pydub

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 21, 2021 •
edited

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110324 run on x86_64-linux 1

5 packages marked as broken and skipped:
  • libsForQt512.kdenlive
  • libsForQt514.kdenlive
  • python37Packages.rl-coach
  • python38Packages.rl-coach
  • python39Packages.baselines
1 package failed to build and already failed to build on hydra master:
  • soundkonverter: log was empty
3 packages failed to build and are new build failures:
  • (libsForQt5.soundkonverter): log was empty
  • libsForQt512.soundkonverter: log was empty
  • libsForQt514.soundkonverter: log was empty
30 packages built:
  • MIDIVisualizer
  • ffmpeg-full
  • handbrake
  • libsForQt5.kdenlive (libsForQt515.kdenlive ,plasma5Packages.kdenlive)
  • libvmaf
  • liquidsoap
  • manim
  • olive-editor
  • printrun
  • python37Packages.baselines
  • python37Packages.gym
  • python37Packages.moderngl-window
  • python37Packages.pydub
  • python37Packages.pyglet
  • python37Packages.pytmx
  • python37Packages.roboschool
  • python38Packages.baselines
  • python38Packages.gym
  • python38Packages.moderngl-window
  • python38Packages.pydub
  • python38Packages.pyglet
  • python38Packages.pytmx
  • python38Packages.roboschool
  • python39Packages.gym
  • python39Packages.moderngl-window
  • python39Packages.pydub
  • python39Packages.pyglet
  • python39Packages.pytmx
  • python39Packages.roboschool
  • webcamoid

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.gym:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'pyglet>=1.2.0,<=1.3.2' doesn't match anything in file 'setup.py'
substituteStream(): WARNING: pattern 'cloudpickle>=1.2.0,<1.4.0' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python38Packages.gym:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'pyglet>=1.2.0,<=1.3.2' doesn't match anything in file 'setup.py'
substituteStream(): WARNING: pattern 'cloudpickle>=1.2.0,<1.4.0' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python39Packages.gym:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'pyglet>=1.2.0,<=1.3.2' doesn't match anything in file 'setup.py'
substituteStream(): WARNING: pattern 'cloudpickle>=1.2.0,<1.4.0' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

builder for '/nix/store/8mxsli029gwf1crhngc88zjhj7wb1jws-aacgain-1.9.0.drv' failed with exit code 2; last 10 log lines:                                                                       libutil/Utility.cpp:551:18: error: narrowing conversion of 'mp4v2::util::Utility::LC_HELP' from 'unsigned int' to 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wnarrowing-Wnarrowing8;;]                                                                                                                                                                       551 |             case LC_HELP:                                                                                                                                                                 |                  ^~~~~~~                                                                                                                                                            libutil/Utility.cpp:555:18: error: narrowing conversion of 'mp4v2::util::Utility::LC_VERSION' from 'unsigned int' to 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wnarrowing-Wnarrowing8;;]                                                                                                                                                                    555 |             case LC_VERSION:                                                                                                                                                              |                  ^~~~~~~~~~                                                                                                                                                         libutil/Utility.cpp:559:18: error: narrowing conversion of 'mp4v2::util::Utility::LC_VERSIONX' from 'unsigned int' to 'int' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wnarrowing-Wnarrowing8;;]                                                                                                                                                                   559 |             case LC_VERSIONX:                                                                                                                                                             |                  ^~~~~~~~~~~                                                                                                                                                        make: *** [GNUmakefile:1316: libutil/Utility.lo] Error 1                                                                                                                                  cannot build derivation '/nix/store/0f95kaya3znxyycljs6i22rsj7rgki00-soundkonverter.drv': 1 dependencies couldn't be built                                                                  cannot build derivation '/nix/store/0zy5ink6qqfj2sw3c5dymd3sls2dsdf7-soundkonverter.drv': 1 dependencies couldn't be built                                                                  cannot build derivation '/nix/store/nzihfq4zz1g9dqg1gsnhiyjm7jw39vbi-soundkonverter.drv': 1 dependencies couldn't be built                                                                  cannot build derivation '/nix/store/wqm1vrp8w5frqiywargvxrscd7skv1y0-env.drv': 3 dependencies couldn't be built

@marsam marsam merged commit 046d244 into NixOS:master Jan 22, 2021
@marsam marsam deleted the update-libvmaf branch January 22, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfsmp3 cfsmp3 Awaiting requested review from cfsmp3

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @SuperSandro2000