Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waybar: 0.9.4 -> 0.9.5 #110273

Merged
merged 1 commit into from Jan 21, 2021
Merged

waybar: 0.9.4 -> 0.9.5 #110273

merged 1 commit into from Jan 21, 2021

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 21, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/aqgwqk9si8a5ncyyl4z422yz7r9wp0s7-waybar-0.9.4 346.1M
/nix/store/dr3k59pc4hywr0y475q830m1mgvwxi2h-waybar-0.9.5 348.5M

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110273 run on x86_64-linux 1

1 package built:
  • waybar

minijackson
minijackson approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

When I saw that Waybar had a new release I was confused about if I should update this in nixpkgs, because of the big "WIP" written in the release. But looking again, I can see that a lots of Linux distributions have updated it, so it should be fine?

Result of nix-review pr 110273 1

1 package were built:
  • waybar

Tested it, works great!

@bbigras
Copy link
Contributor Author

bbigras commented Jan 21, 2021

When I saw that Waybar had a new release I was confused about if I should update this in nixpkgs, because of the big "WIP" written in the release. But looking again, I can see that a lots of Linux distributions have updated it, so it should be fine?

I thought maybe the release note was a WIP...

There's a bit of commits in this, so I'm guessing it's worth it to package it.

@SuperSandro2000 SuperSandro2000 merged commit d2a9ff2 into NixOS:master Jan 21, 2021
@bbigras bbigras deleted the waybar branch January 21, 2021 16:36
@bbigras
Copy link
Contributor Author

bbigras commented Jan 21, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minijackson minijackson minijackson approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@FlorianFranzen FlorianFranzen Awaiting requested review from FlorianFranzen

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbigras @SuperSandro2000 @minijackson