Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildFHSUserEnvBubblewrap: generalize for non-x86_64 #110303

Closed
wants to merge 1 commit into from
Closed

buildFHSUserEnvBubblewrap: generalize for non-x86_64 #110303

wants to merge 1 commit into from

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Jan 21, 2021

Motivation for this change

buildFHSUserEnv does not evaluate for aarch64-linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ehmry ehmry added 0.kind: enhancement 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform labels Jan 21, 2021
@ehmry ehmry marked this pull request as ready for review January 21, 2021 10:46
@ehmry
Copy link
Contributor Author

ehmry commented Jan 21, 2021 •
edited

Tested with anki-bin on x86_64, some custom environments on aarch64.

@akirakyle
Copy link

Recently ran into this issue. Any update on getting this fix merged?

@akirakyle
Copy link

Also I think pkgs/build-support/build-fhs-userenv/env.nix needs the same treatment as was done for pkgs/build-support/build-fhs-userenv-bubblewrap/env.nix here

@ehmry
Copy link
Contributor Author

ehmry commented Apr 5, 2021

@akirakyle this work needs to be rebased.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/plex-on-aarch64/13945/5

@jonringer
Copy link
Contributor

if you resolve the conflicts, I'll be glad to merge :)

@Artturin
Copy link
Member

if you resolve the conflicts, I'll be glad to merge :)

did it for ehmry

jonringer
jonringer reviewed Aug 10, 2021
View reviewed changes
pkgs/build-support/build-fhs-userenv-bubblewrap/env.nix
@@ -32,7 +32,7 @@ let

# list of packages which are installed for both x86 and x86_64 on x86_64
# systems
multiPaths = multiPkgs pkgsi686Linux;
multiPaths = lib.optional isx86_64 (multiPkgs pkgsi686Linux);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still quite a bit different from #132963, in which this will also remove the 32bit versions of all the packages. where as the other will only exclude glibc_multi

@ehmry
Copy link
Contributor Author

ehmry commented Aug 11, 2021

I've lost track of this PR, and I don't have the time or the energy to folllow up. Reopen if someone wants to take over.

@ehmry ehmry closed this Aug 11, 2021
@wegank wegank mentioned this pull request Jan 24, 2022
Closed
@Artturin Artturin mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@Atemu Atemu Awaiting requested review from Atemu

@illegalprime illegalprime Awaiting requested review from illegalprime

Assignees
No one assigned
Labels
0.kind: enhancement 6.topic: portability General portability concerns, not specific to cross-compilation or a specific platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ehmry @akirakyle @nixos-discourse @jonringer @Artturin