Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Actions] Use vcpkg to provide libpng on macOS #8675

Merged
merged 1 commit into from Feb 15, 2021

Conversation

orudge
Copy link
Contributor

@orudge orudge commented Feb 15, 2021

Motivation / Problem

The macOS builds are failing because libpng is missing on ARM64.

Description

vcpkg previously installed libpng as a dependency of freetype. When freetype was removed, libpng was no longer installed. We should have had libpng specified explicitly, but didn't.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@orudge orudge merged commit d3b50b9 into OpenTTD:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants