Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when opening settings window #8676

Closed
Ufiby opened this issue Feb 15, 2021 · 6 comments
Closed

Crash when opening settings window #8676

Ufiby opened this issue Feb 15, 2021 · 6 comments

Comments

@Ufiby
Copy link

Ufiby commented Feb 15, 2021

Version of OpenTTD

20210215-master-gdb246b82ac

Expected result

Should open the setting

Actual result

To open the setting causes an accident

Steps to reproduce

OpenTTD
@James103
Copy link
Contributor

I assume you mean a crash? If so, can you post the corresponding crash.log, crash.dmp, and crash.png files here (zip the crash.dmp first)?

@Ufiby
Copy link
Author

Ufiby commented Feb 15, 2021

OpenTTD.zip

@James103
Copy link
Contributor 

Crash reason:
 Message:   Assertion failed at line 883 of ..\src\settings_gui.cpp: this->setting != nullptr

Can you try resetting your openttd.cfg to default values? For example, move OpenTTD.cfg from C\Users\[user]\Documents\OpenTTD to another folder to allow you to keep the file while also generating a new default configuration.

@Ufiby
Copy link
Author

Ufiby commented Feb 15, 2021

This will not help to solve the problem in any way

@James103
Copy link
Contributor

James103 commented Feb 15, 2021 •
edited

It crashes for me in 20210215-master-gdb246b82ac, but does not crash for me in 20210213-master-g0f621b4956. Likely a regression from PR #8566.

@LordAro
Copy link
Member

LordAro commented Feb 15, 2021

0f621b4...db246b8

More likely a2c3197

It's being worked on

@LordAro LordAro changed the title Unable to open the setting Crash when opening settings window Feb 15, 2021
glx22 added a commit to glx22/OpenTTD that referenced this issue Feb 15, 2021
@glx22
Fix OpenTTD#8676: Revert a2c3197 and unconditionally load settings "e…
c2a0e20 
…arly"
michicc added a commit to michicc/OpenTTD that referenced this issue Feb 15, 2021
@michicc
Fix OpenTTD#8676, a2c3197: GUI-visible settings may not be part of mi…
6d089ab 
…sc settings.
michicc added a commit to michicc/OpenTTD that referenced this issue Feb 16, 2021
@michicc
Fix OpenTTD#8676, a2c3197: GUI-visible settings may not be part of mi…
eac3625 
…sc settings.
michicc added a commit to michicc/OpenTTD that referenced this issue Feb 16, 2021
@michicc
Fix OpenTTD#8676, a2c3197: GUI-visible settings may not be part of mi…
ce1cd13 
…sc settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LordAro @James103 @Ufiby