Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with rapidyaml requirement #19

Closed
ajelinski opened this issue Feb 15, 2021 · 2 comments
Closed

Problems with rapidyaml requirement #19

ajelinski opened this issue Feb 15, 2021 · 2 comments

Comments

@ajelinski
Copy link

There are two problems with rapidyaml:

  1. While installing this package with pip install git+https://github.com/symbiflow/python-fpga-interchange.git, there is an error that rapidyaml can't be found which is true since it's in the setup.py in install_requires but it's not a PIP package.
  2. I'd simply solve it by adding git+https://github.com/litghost/rapidyaml.git@fixup_python_packaging#egg=rapidyaml&subdirectory=api/python before this package in https://github.com/SymbiFlow/fpga-tool-perf/blob/0888f31ca8855141a7648189167cacc2a6749755/conf/nextpnr/requirements.txt#L4 which should solve the problem of the unavailable rapidyaml package, BUT there's an error during its installation. It requires swig to be installed in the environment and adding swig to the Conda's environment.yml doesn't work. I guess it'd be needed to add it in the host OS or which doesn't seem to be the optimal solution.

For now I'll propose to simply lock revision in fpga-tool-perf's nextpnr/requirements.txt and symbiflow/requirements.txt to the last revision prior to using rapidyaml, i.e. e632a5e

BTW. @litghost I'd add the second point as an issue in https://github.com/litghost/rapidyaml/ but there's no Issues tab enabled.

@litghost
Copy link
Contributor

2. It requires swig to be installed in the environment and adding swig to the Conda's environment.yml doesn't work. I guess it'd be needed to add it in the host OS or which doesn't seem to be the optimal solution.

Adding swig to conda is what was done here, and it appears to have worked: f4pga/f4pga-arch-defs#2012

@ajelinski
Copy link
Author

Oh you're right. I've just checked locally that it works. I must've been trying to add swig before I found out that also rapidyaml should be added separately to requirements.txt.

Thanks!

kowalewskijan pushed a commit to antmicro/python-fpga-interchange that referenced this issue Apr 26, 2021
Add entries for default parameters, and how to present parameters as strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants