Feature: Object class selection string filtering #8603
Merged
+194
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0anJosep
reviewed
Jan 23, 2021
perezdidac
commented
Jan 23, 2021
Check the CI results. Also, under "Files Changed" you have references to the warning. |
J0anJosep
reviewed
Jan 31, 2021
J0anJosep
reviewed
Jan 31, 2021
stormcone
reviewed
Feb 10, 2021
Thank you! Addressed your comments. |
LordAro
approved these changes
Feb 19, 2021
|
@perezdidac : just for future learning, if you resolved an issue, you can just hit the "Resolve conversation" button without leaving a comment :) Saves you a lot of time, saves us from reading acknowledgements :D Cheers! |
2TallTyler
added a commit
to 2TallTyler/OpenTTD
that referenced
this pull request
Sep 9, 2021
glx22
pushed a commit
that referenced
this pull request
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Players can use NewGRF in a new game, and some of them contain objects than can be placed on the map. To make it easier for players to browse throughout the list of object classes, this pull request adds a text edit box to the Object Selection window so object classes can be filtered by.
Description
Adding a filter for object classes in the Object Selection window.
Limitations
Note that object classes are filtered by objects themselves are not.
Highlights
I plan to do the same for stations next probably. Or vehicles?
Checklist for review
N/A