-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New commander x16 emulator #111000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New commander x16 emulator #111000
Conversation
{ stdenv, lib | ||
, fetchFromGitHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ stdenv, lib | |
, fetchFromGitHub | |
{ stdenv | |
, lib | |
, fetchFromGitHub |
runHook postInstall | ||
''; | ||
|
||
meta = with lib; { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta should be last.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, meta is the last attribute.
However, in the rare cases when passthru
is used, it comes last.
(The idea of passthru here is in the case someone creates a wrapping script encapsulating the emulator and the rom; according to the upstream site, they are updated at the same time, and older ROMs may not work with newer emulators.)
{ stdenv, lib | ||
, fetchFromGitHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ stdenv, lib | |
, fetchFromGitHub | |
{ stdenv | |
, lib | |
, fetchFromGitHub |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages built:
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages failed to build and are new build failures:
1 package built:
|
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)