Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New commander x16 emulator #111000

Merged
merged 3 commits into from Jan 28, 2021
Merged

New commander x16 emulator #111000

merged 3 commits into from Jan 28, 2021

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jan 28, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Comment on lines 1 to 3
{ stdenv, lib
, fetchFromGitHub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv, lib
, fetchFromGitHub
{ stdenv
, lib
, fetchFromGitHub

runHook postInstall
'';

meta = with lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta should be last.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, meta is the last attribute.
However, in the rare cases when passthru is used, it comes last.

(The idea of passthru here is in the case someone creates a wrapping script encapsulating the emulator and the rom; according to the upstream site, they are updated at the same time, and older ROMs may not work with newer emulators.)

Comment on lines 1 to 3
{ stdenv, lib
, fetchFromGitHub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv, lib
, fetchFromGitHub
{ stdenv
, lib
, fetchFromGitHub

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111000 run on x86_64-linux 1

2 packages built:
  • x16-emulator
  • x16-rom

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111000 run on x86_64-darwin 1

2 packages failed to build and are new build failures:
1 package built:
  • x16-emulator

@AndersonTorres AndersonTorres merged commit 2520b03 into NixOS:master Jan 28, 2021
@AndersonTorres AndersonTorres deleted the new-commander-x16 branch January 29, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants