Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfce.xfce4-i3-workspaces-plugin: init at 1.4.0 #110995

Merged

Conversation

berbiche
Copy link
Member

Motivation for this change

Add "a workspace switcher plugin for xfce4-panel which can be used for the i3 window manager".

https://github.com/denesb/xfce4-i3-workspaces-plugin

Tests were done by integrating this plugin in my xfce panel configuration.
image

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 28, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110995 run on x86_64-linux 1

1 package built:
  • xfce.xfce4-i3-workspaces-plugin

@berbiche berbiche force-pushed the init-xfce4-i3-workspaces-plugin branch from 30479d4 to c1ee2f8 Compare January 28, 2021 17:45
@SuperSandro2000 SuperSandro2000 merged commit 4681599 into NixOS:master Jan 28, 2021
@berbiche
Copy link
Member Author

Thanks @SuperSandro2000 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants