Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open-isns: 0.99 -> 0.100 #111009

Merged
merged 2 commits into from Jan 28, 2021
Merged

open-isns: 0.99 -> 0.100 #111009

merged 2 commits into from Jan 28, 2021

Conversation

markuskowa
Copy link
Member

Motivation for this change

https://github.com/open-iscsi/open-isns/blob/v0.100/ChangeLog

Things done
  • Update + add upstream patches
  • Update Github repo source and homepage
  • add maintainer
  • Fix attribute to match official name
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change.
    Tested with out of tree test: https://github.com/markuskowa/nix-system/blob/master/tests/isns.nix
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from cleverca22 and zaninime January 28, 2021 12:22
@markuskowa
open-isns: 0.99 -> 0.100
1e160f9 
* update homepage + git repo source
* add maintainer
@markuskowa
openisns: change attribute to open-isns
8862391 
Make attribute consitent with pname to match the official name.
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111009 run on x86_64-linux 1

2 packages built:
  • open-isns
  • openiscsi

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

openiscsi:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '/sbin' doesn't match anything in file '/nix/store/j7nr2xfsay6s8kzf7gkdbi61a8vg1wqs-open-iscsi-2.1.3/lib/systemd/system/iscsid.socket'
substituteStream(): WARNING: pattern '/sbin' doesn't match anything in file '/nix/store/j7nr2xfsay6s8kzf7gkdbi61a8vg1wqs-open-iscsi-2.1.3/lib/systemd/system/iscsiuio.socket'

Please check the offending substituteInPlace for typos or changes in source.

@markuskowa
Copy link
Member Author

I'll fix the offending substituteInPlace in open-iscsi in another PR. This is out of scope here.

@markuskowa markuskowa merged commit e29bef4 into NixOS:master Jan 28, 2021
@markuskowa markuskowa deleted the upd-isns branch January 28, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@zaninime zaninime zaninime approved these changes

@cleverca22 cleverca22 Awaiting requested review from cleverca22

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @SuperSandro2000 @zaninime