Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark: init at version 3.5 #110996

Merged
merged 2 commits into from Jan 30, 2021
Merged

mark: init at version 3.5 #110996

merged 2 commits into from Jan 30, 2021

Conversation

rguevara84
Copy link
Contributor

  • A tool for syncing your markdown documentation with Atlassian
    Confluence pages
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 28, 2021
View reviewed changes
pkgs/tools/text/mark/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/mark/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from kalbasit January 28, 2021 09:17
kalbasit
kalbasit reviewed Jan 28, 2021
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at their Makefile, there's a way to embed the version in the binary by passing -X main.version=${version} as ldflags. I'm afk so I don't have the syntax at hand, you can grep nixpkgs for ldflags in files that also has buildGoModule to find an example; Once you get it done, ask mark to display its version to double check that it worked.

pkgs/tools/text/mark/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/mark/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from kalbasit January 29, 2021 21:35
@kalbasit
Copy link
Member

@rguevara84 can you squash the init with the pr feedback. At the end you should have two commit, one for adding you as a maintainer and the other for mark init.

@rguevara84
mark: init at version 3.5
a486c97 
* A tool for syncing your markdown documentation with Atlassian
  Confluence pages

pr feedback
@rguevara84
maintainers: add rguevara84
de25d12
@kalbasit
Copy link
Member

@GrahamcOfBorg build mark

@kalbasit
Copy link
Member 

[nix-shell:~/.cache/nixpkgs-review/pr-110996]$ ./results/mark/bin/mark --version
3.5

Looks good.

@SuperSandro2000 PTAL.

@SuperSandro2000 SuperSandro2000 merged commit 767fc05 into NixOS:master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rguevara84 @kalbasit @SuperSandro2000