Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixUnstable: patch #4470 (ETag) #111005

Merged
merged 2 commits into from Jan 28, 2021
Merged

nixUnstable: patch #4470 (ETag) #111005

merged 2 commits into from Jan 28, 2021

Conversation

roberth
Copy link
Member

@roberth roberth commented Jan 28, 2021 •
edited

Motivation for this change

Make nixUnstable usable.

NixOS/nix#4469

Proper update seems blocked #109309 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth roberth added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 28, 2021
@ofborg ofborg bot requested a review from edolstra January 28, 2021 10:59
@roberth roberth requested a review from Ma27 January 28, 2021 12:56
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111005 run on x86_64-darwin 1

3 packages built:
  • nix-update
  • nixFlakes (nixUnstable)
  • nixpkgs-review

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111005 run on x86_64-linux 1

4 packages built:
  • hydra-unstable
  • nix-update
  • nixFlakes (nixUnstable)
  • nixpkgs-review

@roberth @Mic92
nixUnstable: use commit url for patch
f56fa95 
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
@Mic92 Mic92 merged commit 1d41739 into NixOS:master Jan 28, 2021
@Mic92
Copy link
Member

Mic92 commented Jan 28, 2021

backport: #111035

Mic92 pushed a commit to Mic92/nixpkgs that referenced this pull request Jan 28, 2021
@roberth @Mic92
nixUnstable: patch NixOS#4470 (ETag) (NixOS#111005)
c560b41 
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
(cherry picked from commit 1d41739)
roberth added a commit that referenced this pull request Jan 29, 2021
@roberth
Merge pull request #111035 from Mic92/nix-backport
683c553 
[20.09] nixUnstable: patch #4470 (ETag) (#111005)
aforemny pushed a commit to aforemny/nixpkgs that referenced this pull request Mar 4, 2021
@roberth @Mic92 @aforemny
nixUnstable: patch NixOS#4470 (ETag) (NixOS#111005)
d442554 
Co-authored-by: Jörg Thalheim <Mic92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@Ma27 Ma27 Awaiting requested review from Ma27 Ma27 is a code owner

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roberth @SuperSandro2000 @Mic92 @Ma27