Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fwup: 1.5.2 -> 1.8.3 #111006

Merged
merged 1 commit into from Feb 19, 2021
Merged

fwup: 1.5.2 -> 1.8.3 #111006

merged 1 commit into from Feb 19, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 28, 2021

Motivation for this change

Update to latest upstream release 1.8.3

Change log: https://github.com/fhunleth/fwup/blob/main/CHANGELOG.md

Fixes #110991

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Jan 28, 2021

Result of nixpkgs-review pr 111006 run on x86_64-linux 1

1 package built:
  • fwup

@fabaff fabaff mentioned this pull request Jan 28, 2021
Closed
2 tasks
@ofborg ofborg bot requested a review from georgewhewell January 28, 2021 11:00
georgewhewell
georgewhewell approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@georgewhewell georgewhewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danieldk
danieldk reviewed Jan 28, 2021
View reviewed changes
pkgs/tools/misc/fwup/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/fwup/default.nix Outdated Show resolved Hide resolved
SuperSandro2000
SuperSandro2000 requested changes Jan 28, 2021
View reviewed changes
pkgs/tools/misc/fwup/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/fwup/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from georgewhewell February 15, 2021 21:06
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111006 run on x86_64-linux 1

1 package built:
  • fwup

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

fwup:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/misc/fwup/default.nix:34:15:

   |
34 |   patches = [ ./fix-testrunner-darwin.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: darwin.
Near pkgs/tools/misc/fwup/default.nix:5:3:

  |
5 | , darwin
  |   ^

SuperSandro2000
SuperSandro2000 reviewed Feb 17, 2021
View reviewed changes
pkgs/tools/misc/fwup/default.nix Outdated
, lib
, fetchFromGitHub
, autoreconfHook
, darwin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, darwin

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, thanks.

@SuperSandro2000 SuperSandro2000 merged commit c2c24f1 into NixOS:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@georgewhewell georgewhewell Awaiting requested review from georgewhewell

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fwup is out-of-date
4 participants
@fabaff @SuperSandro2000 @danieldk @georgewhewell