Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernelPatches: drop export_kernel_fpu_functions #110958

Merged
merged 1 commit into from Jan 27, 2021
Merged

kernelPatches: drop export_kernel_fpu_functions #110958

merged 1 commit into from Jan 27, 2021

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Jan 27, 2021 •
edited

Hasn't been necessary since ZFS 0.8.3

Motivation for this change

Closes #110956

Ideally merge this right before a stable kernel bump to avoid unnecessary rebuilds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu
kernelPatches: drop export_kernel_fpu_functions
85dfff3 
Hasn't been necessary since ZFS 0.8.3
@Atemu Atemu mentioned this pull request Jan 27, 2021
Closed
10 tasks
@SuperSandro2000
Copy link
Member

Do we want to target staging with this?

@Mic92
Copy link
Member

Mic92 commented Jan 27, 2021

Maybe?

@NeQuissimus
Copy link
Member

It should be OK to just remove this. There is a new batch of kernels coming anyways, let's merge this in.

@NeQuissimus NeQuissimus merged commit 88f877e into NixOS:master Jan 27, 2021
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 27, 2021 •
edited

I basically can newer build kernel modules if I always need to build a few different kernels. :/

@Atemu Atemu deleted the kernelPatches-drop-export_kernel_fpu_functions branch January 28, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kernelPatches.export_kernel_fpu_functions doesn't apply on 5.10.11
4 participants
@Atemu @SuperSandro2000 @Mic92 @NeQuissimus