Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.canmatrix: 0.9.1 -> 0.9.3 #111007

Merged
merged 3 commits into from Feb 4, 2021
Merged

python3Packages.canmatrix: 0.9.1 -> 0.9.3 #111007

merged 3 commits into from Feb 4, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 28, 2021

Motivation for this change

Update to latest upstream release 0.9.3

Commit log: https://github.com/ebroecker/canmatrix/commits/development

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from sorki January 28, 2021 11:29
@fabaff
Copy link
Member Author

fabaff commented Jan 28, 2021

Result of nixpkgs-review pr 111007 run on x86_64-linux 1

6 packages built:
  • python37Packages.canmatrix
  • python37Packages.canopen
  • python38Packages.canmatrix
  • python38Packages.canopen
  • python39Packages.canmatrix
  • python39Packages.canopen

@fabaff fabaff mentioned this pull request Jan 28, 2021
Merged
sorki
sorki approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@sorki sorki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you! Consider adding yourself to maintainers :-)

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111007 run on x86_64-darwin 1

3 packages failed to build and are new build failures:
  • python37Packages.canopen: log was empty
  • python38Packages.canopen: log was empty
  • python39Packages.canopen: log https://termbin.com/tvi1
3 packages built:
  • python37Packages.canmatrix
  • python38Packages.canmatrix
  • python39Packages.canmatrix

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111007 run on x86_64-linux 1

6 packages built:
  • python37Packages.canmatrix
  • python37Packages.canopen
  • python38Packages.canmatrix
  • python38Packages.canopen
  • python39Packages.canmatrix
  • python39Packages.canopen

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111007 run on x86_64-darwin 1

3 packages failed to build and are new build failures:
  • python37Packages.canopen: log was empty
  • python38Packages.canopen: log was empty
  • python39Packages.canopen: log https://termbin.com/n16g
3 packages built:
  • python37Packages.canmatrix
  • python38Packages.canmatrix
  • python39Packages.canmatrix

@mweinelt
Copy link
Member

mweinelt commented Feb 4, 2021

Ah, sorry. I came upon the same issue and fixed it in cb4fe8e. Can you rebase, sorry for not checking the pull requests first.

@ofborg ofborg bot requested a review from sorki February 4, 2021 08:19
@mweinelt mweinelt merged commit c6f1287 into NixOS:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@sorki sorki Awaiting requested review from sorki

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fabaff @SuperSandro2000 @mweinelt @sorki