Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backported latest changes from master #110955

Closed

Conversation

anandsuresh
Copy link
Contributor

@anandsuresh anandsuresh commented Jan 27, 2021

Motivation for this change

Terraform has undergone some major changes which makes it unusable with v20.09; mainly a change that prevents using symlinks to identify plugins. Terraform implemented this change to prevent infinite loops when trying to search for plugins. However, this breaks terraform since the nix-store relies heavily on symlinks.

This commit backports the latest changes from master to ensure terraform runs as expected on v20.09.

Things done

In a fully sync'd repository, starting from branch release-20.09, I ran the following:

git checkout master -- pkgs/applications/networking/cluster/terraform
git checkout master -- pkgs/applications/networking/cluster/terraform-providers
git commit -am "Backported latest changes from master"
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Terraform has undergone some major changes which makes it unusable with 
v20.09. This commit backports the latest changes from master.
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anandsuresh
Copy link
Contributor Author

Reopened as #110964 following contribution guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants