Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libqb: 0.17.2 -> 2.0.2 #110952

Merged
merged 1 commit into from Jan 30, 2021
Merged

libqb: 0.17.2 -> 2.0.2 #110952

merged 1 commit into from Jan 30, 2021

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented Jan 27, 2021 •
edited

Motivation for this change

Fixes CVE-2019-12779.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

3 packages built:
  • corosync
  • libqb
  • usbguard (usbguard-nox)

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110952 run on x86_64-darwin 1

1 package failed to build and are new build failure:

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110952 run on x86_64-linux 1

3 packages built:
  • corosync
  • libqb
  • usbguard

@danieldk
Copy link
Contributor

I made some small changes:

  • Make the layout more canonical.
  • Changed the license to lgpl21Plus, the source files give the option of using a later version.

Will merge once ofborg is happy.

danieldk
danieldk approved these changes Jan 30, 2021
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Could you backport this to 20.09?

@danieldk danieldk merged commit 44c8df7 into NixOS:master Jan 30, 2021
@LeSuisse LeSuisse added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 3, 2021
@LeSuisse LeSuisse deleted the libqb-2.0.2 branch February 3, 2021 19:53
@LeSuisse LeSuisse added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 17, 2021
@yorickvP yorickvP mentioned this pull request Aug 19, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeSuisse @SuperSandro2000 @danieldk