Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdma-core: 33.0 -> 33.1 #111001

Merged
merged 1 commit into from Jan 29, 2021
Merged

rdma-core: 33.0 -> 33.1 #111001

merged 1 commit into from Jan 29, 2021

Conversation

markuskowa
Copy link
Member

Motivation for this change

Changelog: https://github.com/linux-rdma/rdma-core/releases/tag/v33.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member Author

@GrahamcOfBorg build opensm openmpi

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 111001 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • python37Packages.pyslurm
  • python38Packages.pyslurm
  • python39Packages.pyslurm

1 similar comment
@SuperSandro2000

This comment has been minimized.

Sign in to view
@markuskowa
Copy link
Member Author

rdma-core is Linux-only package (no Darwin).

SuperSandro2000
SuperSandro2000 reviewed Jan 28, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the license gpl2Only or gpl2Plus?

@markuskowa markuskowa merged commit 8c72a38 into NixOS:master Jan 29, 2021
@markuskowa markuskowa deleted the upd-rdma-core branch January 29, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markuskowa @SuperSandro2000