Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] qutebrowser: 1.13.1 -> 1.14.1 #110997

Merged
merged 2 commits into from Jan 31, 2021
Merged

[20.09] qutebrowser: 1.13.1 -> 1.14.1 #110997

merged 2 commits into from Jan 31, 2021

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jan 28, 2021

Motivation for this change

This release includes several fixes for incompatibe changes introduced
by the Qt 5.15.2 update, which was backported to NixOS 20.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change (qutebrowser)
  • Tested execution of all binary files
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

chvp and others added 2 commits January 28, 2021 08:42
@chvp @rnhmjoj
qutebrowser: 1.13.1 -> 1.14.0
4c3fe53 
(cherry picked from commit 0ff5728)
@rnhmjoj
qutebrowser: 1.14.0 -> 1.14.1
9405be8 
(cherry picked from commit 82c99e2)

This release includes several fixes for incompatibe changes introduced
by the Qt 5.15.2 update, which was backported to NixOS 20.09.
@ofborg ofborg bot requested review from ebzzry and jagajaga January 28, 2021 08:11
@The-Compiler
Copy link
Contributor

FWIW I've released v2.0.0 in the meantime - also see #108272.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jan 28, 2021

Thank you, I'm aware of 2.0 but this a backport to the stable channel.
2.0 should be backported, probably.

ghost
ghost approved these changes Jan 28, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could discuss if this backport is strictly necessary (as we did in #107232), but I approve of this since I have been using qutebrowser 1.14.1 as my everyday browser for a long time now (and the change looks okay otherwise).

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jan 28, 2021

Well, it's not super important but I have just updated the channel and noticed the dark mode was broken with the new Qt, as mentioned in the release notes. This update seems to fix that, at least partially.

@rnhmjoj rnhmjoj merged commit ccaf48f into NixOS:release-20.09 Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebzzry ebzzry Awaiting requested review from ebzzry

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @The-Compiler @chvp