Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tailscale: 1.2.10 -> 1.4.0 #110977

Merged
merged 1 commit into from Jan 28, 2021
Merged

tailscale: 1.2.10 -> 1.4.0 #110977

merged 1 commit into from Jan 28, 2021

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jan 28, 2021

Motivation for this change

Note that the systemd service file now has more hardening.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bbigras
Copy link
Contributor Author

bbigras commented Jan 28, 2021

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jan 28, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 28, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@bbigras bbigras mentioned this pull request Jan 28, 2021
Closed
10 tasks
@Xe
Copy link
Contributor

Xe commented Jan 28, 2021

I have tested this patch and can confirm that it works.

danderson
danderson approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@danderson danderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

(approving this one rather than my PR to see what mergebot thinks :) )

@danderson
Copy link
Contributor

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from kevincox January 28, 2021 02:48
@marsam marsam merged commit 1eec15c into NixOS:master Jan 28, 2021
@bbigras bbigras deleted the tailscale branch January 28, 2021 03:45
@bbigras
Copy link
Contributor Author

bbigras commented Jan 28, 2021

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danderson danderson danderson approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@martinbaillie martinbaillie Awaiting requested review from martinbaillie

@kevincox kevincox Awaiting requested review from kevincox

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @Xe @danderson @marsam