Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update META.yml #27521

Merged
merged 1 commit into from Feb 22, 2021
Merged

Update META.yml #27521

merged 1 commit into from Feb 22, 2021

Conversation

svgeesus
Copy link
Contributor

@svgeesus svgeesus commented Feb 8, 2021

Add Sam Weinig to CSS Color reviewers

Add Sam Weinig to CSS Color reviewers
@svgeesus
Copy link
Contributor Author

@smfr @tabatkins @foolip could someone please review and merge? Sam Weinig is implementing CSS Color 4 in Webkit, and also creating WPT tests. I can review his tests, but he can't review mine like this one so they sit for weeks waiting for review.

@foolip
Copy link
Member

foolip commented Feb 16, 2021

@svgeesus in addition to being listed in META.yml, one must also be a member of the reviewers team to have write access. @weinig I've sent an invite to you, which you should see at the top of https://github.com/web-platform-tests. After accepting, you'll probably want to follow the instructions at https://github.com/orgs/web-platform-tests/teams/reviewers/discussions/1 to unwatch the repositories, since you'll otherwise get way too many notifications.

This change would make sense to merge after @weinig has accepted the invite. The reviewer assigner bot can't assign anyone who isn't an org member, so just being listed in META.yml doesn't do much.

@svgeesus
Copy link
Contributor Author

@weinig did you accept the invite?

@weinig
Copy link
Contributor

weinig commented Feb 22, 2021

@weinig did you accept the invite?

I did (I think anyway).

@foolip
Copy link
Member

foolip commented Feb 22, 2021

@weinig, I can confirm you're now in the reviewers team. You can try out your powers by approving and merging this PR :)

@weinig weinig self-requested a review February 22, 2021 18:26
@weinig weinig merged commit 10d594d into master Feb 22, 2021
@weinig weinig deleted the svgeesus-patch-1 branch February 22, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants